This repository was archived by the owner on Jun 20, 2025. It is now read-only.
Modify PCSContainerInstance to use keyword arguments (#400) #1421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h#400) Summary: X-link: facebookresearch/fbpcp#400 ## Context We want to enable customized containers in our infra ([design doc](https://docs.google.com/document/d/1UqaK6VXEoIVUHSJnYs_Ydju8)). Therefore we need to add cpu & memory properties to ContainerInstance; ## This commit Change ```PCSContainerInstance``` to use keyword arguments to prevent breaks when we add cpu and memory to ```ContainerInstance ``` later Differential Revision: D38553232 fbshipit-source-id: b96624305a4443e5ec7801d0f44f258132bceba0
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D38553232 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: facebookresearch/fbpcp#400
Context
We want to enable customized containers in our infra (design doc). Therefore we need to add cpu & memory properties to ContainerInstance;
This commit
Change
PCSContainerInstanceto use keyword arguments to prevent breaks when we add cpu and memory toContainerInstancelaterDifferential Revision: D38553232