Skip to content
This repository was archived by the owner on Jun 20, 2025. It is now read-only.

Remove partial dependency in PCSContainerService (#405) #1428

Closed
zhuang-93 wants to merge 1 commit into from
Closed

Remove partial dependency in PCSContainerService (#405) #1428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fbpcs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Types of changes
### Added

### Changed

- Mark validate_container_definition as deprecated in PCSContainerService since it is no longer a public method in ContainerService in fbpcp
### Removed

## [1.10.0] - 2022-08-12
Expand Down
9 changes: 6 additions & 3 deletions fbpcs/common/service/pcs_container_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
from fbpcs.common.entity.pcs_container_instance import PCSContainerInstance
from fbpcs.experimental.cloud_logs.log_retriever import CloudProvider, LogRetriever

from fbpcs.private_computation.service.utils import deprecated


class PCSContainerService(ContainerService):
def __init__(self, inner_container_service: ContainerService) -> None:
Expand Down Expand Up @@ -80,7 +82,8 @@ def cancel_instances(self, instance_ids: List[str]) -> List[Optional[PcpError]]:
def get_current_instances_count(self) -> int:
return self.inner_container_service.get_current_instances_count()

@deprecated(
"validate_container_definition is no longer a public method in container service"
)
def validate_container_definition(self, container_definition: str) -> None:
return self.inner_container_service.validate_container_definition(
container_definition
)
pass