Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydra CI failures #2841

Closed
8 of 9 tasks
Jasha10 opened this issue Jan 19, 2024 · 1 comment · Fixed by #2842
Closed
8 of 9 tasks

Hydra CI failures #2841

Jasha10 opened this issue Jan 19, 2024 · 1 comment · Fixed by #2842
Labels
bug Something isn't working

Comments

@Jasha10
Copy link
Collaborator

Jasha10 commented Jan 19, 2024

Hydra CI is suffering from a number of failures.
These failures should all be reproducible via nox.
For example, to reproduce the lint-3.7 failure, run nox -s lint-3.7 using python version 3.7.
To reproduce the lint_plugins-3.8(hydra-nevergrad-sweeper) failure, run nox -s 'lint_plugins-3.8(hydra-nevergrad-sweeper)' using python version 3.8.

git clone https://github.com/facebookresearch/hydra
cd hydra
# Check that we're using python version 3.7:
[[ $(python --version) =~ "Python 3.7." ]] || echo "not using python3.7"
pip install nox
nox -s lint-3.7
  • lint-3.7
    • CI logs demonstrating failure
    • PR where CI failure occurred: mypy lint #2840
    • excerpt from log files:
      File "/home/circleci/project/.nox/lint-3-7/lib/python3.7/site-packages/flake8/plugins/manager.py", line 254, in _load_entrypoint_plugins eps = importlib_metadata.entry_points().get(self.namespace, ()) AttributeError: 'EntryPoints' object has no attribute 'get' nox > [2024-01-18 12:31:05,224] Command flake8 --config .flake8 failed with exit code 1 nox > [2024-01-18 12:31:05,225] Session lint-3.7 failed.
    • Possible Remedies:
    • fixed by: Fix CI failures #2842
  • lint_plugins-3.8(hydra-nevergrad-sweeper)
    • CI logs demonstrating failure
    • nature of failure: mypy
    • except from log files:
      plugins/hydra_nevergrad_sweeper/hydra_plugins/hydra_nevergrad_sweeper/_impl.py:15: error: Skipping analyzing "nevergrad": module is installed, but missing library stubs or py.typed marker [import-untyped] plugins/hydra_nevergrad_sweeper/hydra_plugins/hydra_nevergrad_sweeper/_impl.py:15: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports plugins/hydra_nevergrad_sweeper/hydra_plugins/hydra_nevergrad_sweeper/_impl.py:79: error: Unused "type: ignore" comment [unused-ignore]
    • fixed by: Fix CI failures #2842
  • lint_plugins-3.8(hydra-rq-launcher)
    • CI logs demonstrating failure
    • nature of failure: mypy
    • excerpt from log files:
      plugins/hydra_rq_launcher/hydra_plugins/hydra_rq_launcher/_core.py:22: error: Unused "type: ignore" comment [unused-ignore] plugins/hydra_rq_launcher/hydra_plugins/hydra_rq_launcher/_core.py:127: error: Argument after ** must be a mapping, not "Union[Dict[Union[str, bytes, int, Enum, float, bool], Any], Dict[Any, Any]]" [arg-type]
    • fixed by: Fix CI failures #2842
  • test_plugins-3.8(hydra-ax-sweeper)
  • test_plugins-3.8(hydra-optuna-sweeper)
    • CI logs demonstrating failure
    • nature of failure: usage of old optuna version?
    • excerpt from log files:
      ../../.nox/test_plugins-3-8-hydra-optuna-sweeper/lib/python3.8/site-packages/sqlalchemy/util/langhelpers.py:1899: in _warnings_warn warnings.warn(message, stacklevel=stacklevel + 1) E sqlalchemy.exc.MovedIn20Warning: The ``declarative_base()`` function is now available as sqlalchemy.orm.declarative_base(). (deprecated since: 2.0) (Background on SQLAlchemy 2.0 at: https://sqlalche.me/e/b8d9)
    • related PR: Upgrade Optuna from v2.x.x to v3.0.0 #2360
    • fixed by: Fix CI failures #2842
  • test_plugins-3.8(hydra-ray-launcher)
    • CI logs demonstrating failure
    • related PR: Ray Launcher Plugin support for Python 3.11 #2778
    • excerpt from log files:
      File "/home/circleci/project/.nox/test_plugins-3-8-hydra-ray-launcher/lib/python3.8/site-packages/ray/_private/services.py", line 2041, in determine_plasma_store_config raise ValueError( ValueError: Attempting to cap object store memory usage at 70864896 bytes, but the minimum allowed is 78643200 bytes.
  • test_plugins-3.8(hydra-rq-launcher)
  • test_plugins-3.8(hydra-submitit-launcher)
    • CI logs demonstrating failure
    • nature of failure: deprecation warning
    • excerpt from log files:
      File "/home/circleci/project/.nox/test_plugins-3-8-hydra-submitit-launcher/lib/python3.8/site-packages/pkg_resources/__init__.py", line 118, in <module> warnings.warn( DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
      • possible remedies: update the pytest deprecation warnings filter used in noxfile.py or pyproject.py
    • fixed by: Fix CI failures #2842
  • test_plugins_vs_core-3.8
    • CI logs demonstrating failure
    • nature of failure: deprecation warning
    • excerpt from log files:
      .nox/test_plugins_vs_core-3-8/lib/python3.8/site-packages/pkg_resources/__init__.py:118: in <module> warnings.warn( E DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
    • possible remedies: update the pytest deprecation warnings filter used in noxfile.py or pyproject.py
    • fixed by: Fix CI failures #2842

In this issue I've just focused on python3.7 and python3.8, which is where the most failures are occurring

@odelalleau
Copy link
Collaborator

Just a note that we should prioritize Python 3.8+ failures since the plan is to drop support for Python 3.7.

@shchur shchur mentioned this issue Jan 19, 2024
10 tasks
@Jasha10 Jasha10 reopened this Jan 23, 2024
@Jasha10 Jasha10 closed this as completed Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants