-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI failures #2842
Merged
Merged
Fix CI failures #2842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jasha10
approved these changes
Jan 22, 2024
Yes, I think so. Thank you, @shchur. |
I will rebase #2733 to include these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixing CI issues described in #2841.
CI failures fixed by this PR
importlib-metadata<5.0
for Python <= 3.7 inrequirements/dev.txt
# type: ignore
comments inplugins/hydra_nevergrad_sweeper/hydra_plugins/hydra_nevergrad_sweeper/_impl.py
nevergrad
module in.mypy.ini
# type: ignore
comments inplugins/hydra_rq_launcher/hydra_plugins/hydra_rq_launcher/_core.py
rq
module in.mypy.ini
pandas<1.5.0
inplugins/hydra_ax_sweeper/setup.py
. This dependency should be unpinned when upgrading ax to>=0.2.8
.Pinned
sqlalchemy~=1.3.0
inplugins/hydra_optuna_sweeper/setup.py
. This dependency should be unpinned in Upgrade Optuna from v2.x.x to v3.0.0 #2360 when upgradingoptuna
to>=3.0
.Alternatively, we could go for a more permissive version range
sqlalchemy>=1.3.0,<2.0.0
, but that would require addingignore:
statement for warnings produced bysqlalchemy
topytest.ini
rq>=1.5.1,<1.12
inplugins/hydra_rq_launcher/setup.py
. This is the highest version for which the tests pass,<1.13
leads to failures.allow_warnings=True
intest_example
inplugins/hydra_submitit_launcher/tests/test_submitit_launcher.py
ignore:.*pkg_resources is deprecated*
inpytest.ini
. DeprecationWarning comes from other package (submitit
), so we have no way to fix them on thehydra
side.importlib.metadata.version
instead ofpkg_resources.get_distribution
inplugins/hydra_ray_launcher/hydra_plugins/hydra_ray_launcher/_config.py
.Errors that I was unable to fix
test_plugins-3.8(hydra-ray-launcher), test_plugins-3.9(hydra-ray-launcher)
object_store_memory
to78643200
, as recommended in ValueError: After taking into account object store and redis memory usage, the amount of memory on this node available for tasks and actors (-0.01 GB) is less than 0% of total. You can adjust these settings with ray.init(memory=<bytes>, object store memory=<bytes> ray-project/ray#11966 (comment), did not help.Possible solutions:
lint_plugins-3.7(hydra-nevergrad-sweeper), lint_plugins-3.7(hydra-ray-launcher), test_plugins-3.7(hydra-ray-launcher), test_plugins_vs_core-3.7
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
This PR does not introduce any new functionality, so no new tests are needed. Only existing tests will be fixed.
Related Issues and PRs
This PR resolves #2841