Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures #2842

Merged
merged 10 commits into from
Jan 22, 2024
Merged

Fix CI failures #2842

merged 10 commits into from
Jan 22, 2024

Conversation

shchur
Copy link
Contributor

@shchur shchur commented Jan 19, 2024

Motivation

Fixing CI issues described in #2841.

CI failures fixed by this PR

  • lint-3.7
    • Pinned importlib-metadata<5.0 for Python <= 3.7 in requirements/dev.txt
  • lint_plugins-3.8(hydra-nevergrad-sweeper)
    • Remove # type: ignore comments in plugins/hydra_nevergrad_sweeper/hydra_plugins/hydra_nevergrad_sweeper/_impl.py
    • Ignore nevergrad module in .mypy.ini
  • lint_plugins-3.8(hydra-rq-launcher)
    • Add / remove # type: ignore comments in plugins/hydra_rq_launcher/hydra_plugins/hydra_rq_launcher/_core.py
    • Ignore rq module in .mypy.ini
  • test_plugins-3.8(hydra-ax-sweeper)
    • Pinned pandas<1.5.0 in plugins/hydra_ax_sweeper/setup.py. This dependency should be unpinned when upgrading ax to >=0.2.8.
  • test_plugins-3.8(hydra-optuna-sweeper)
    • Pinned sqlalchemy~=1.3.0 in plugins/hydra_optuna_sweeper/setup.py. This dependency should be unpinned in Upgrade Optuna from v2.x.x to v3.0.0 #2360 when upgrading optuna to >=3.0.

      Alternatively, we could go for a more permissive version range sqlalchemy>=1.3.0,<2.0.0, but that would require adding ignore: statement for warnings produced by sqlalchemy to pytest.ini

  • test_plugins-3.8(hydra-rq-launcher)
    • Pinned rq>=1.5.1,<1.12 in plugins/hydra_rq_launcher/setup.py. This is the highest version for which the tests pass, <1.13 leads to failures.
  • test_plugins-3.8(hydra-submitit-launcher)
    • Set allow_warnings=True in test_example in plugins/hydra_submitit_launcher/tests/test_submitit_launcher.py
    • Add line ignore:.*pkg_resources is deprecated* in pytest.ini. DeprecationWarning comes from other package (submitit), so we have no way to fix them on the hydra side.
  • test_plugins_vs_core-3.8
    • Use importlib.metadata.version instead of pkg_resources.get_distribution in plugins/hydra_ray_launcher/hydra_plugins/hydra_ray_launcher/_config.py.

Errors that I was unable to fix

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

This PR does not introduce any new functionality, so no new tests are needed. Only existing tests will be fixed.

Related Issues and PRs

This PR resolves #2841

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 19, 2024
@shchur shchur changed the title Fix CI failures WIP: Fix CI failures Jan 19, 2024
@shchur shchur changed the title WIP: Fix CI failures Fix CI failures Jan 20, 2024
@shchur
Copy link
Contributor Author

shchur commented Jan 20, 2024

@Jasha10 all the tests except test_plugins-3.8(hydra-ray-launcher) are now passing for Python 3.8, 3.9, 3.10, 3.11. Do you think this is sufficient to unblock #2733?

@Jasha10
Copy link
Collaborator

Jasha10 commented Jan 22, 2024

Yes, I think so. Thank you, @shchur.

@Jasha10 Jasha10 merged commit 6ff79b1 into facebookresearch:main Jan 22, 2024
24 of 29 checks passed
@shchur shchur deleted the fix-ci-bugs branch January 23, 2024 07:46
@Jasha10 Jasha10 mentioned this pull request Jan 23, 2024
9 tasks
@jlopezpena
Copy link
Contributor

I will rebase #2733 to include these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydra CI failures
4 participants