Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add args and kwargs keys and arguments in raise #2233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AntreasAntoniou
Copy link

Debugging issues without the given arguments and kwarguments is needlessly complex, I am adding such details to make it easier.

Motivation

I have found that debugging issues regarding arguments and kwarguments without any clues as to what those are is needlessly hard. I have decided to include those in my error reporting messages, and I think the wider community would benefit from that as well.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Standard/existing tests involving implemented Exceptions should suffice.

Debugging issues without the given arguments and kwarguments is needlessly complex, I am adding such details to make it easier.
@facebook-github-bot
Copy link
Contributor

Hi @AntreasAntoniou!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 25, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@jieru-hu
Copy link
Contributor

thanks for the contribution @AntreasAntoniou - it looks like you need to update the tests as well.
here's out developer guide in case it helps https://hydra.cc/docs/development/testing/

@jieru-hu jieru-hu self-requested a review May 26, 2022 21:36
Copy link
Contributor

@jieru-hu jieru-hu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants