Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert circleci jobs to github actions #2900

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robandpdx
Copy link

Motivation

This pull request converts the CircleCI workflows to GitHub actions workflows.

Notes

I chose the use the microsoft version of openjdk. See supported distributions for other options.

Ubuntu 18.04 reached EOL May 2023. I have removed this job that tests on this OS version from the workflow.

It may be desireable to set fail-fast: true in order to save $ on runners when jobs fail. I set this to true in order to see the results of all jobs.

There is currently a defect in the conda-incubator/setup-miniconda action, I believe. The CONDA environment variable is not set in the environment in all conditions. I have created an issue in the repo for this. My PR here solves the issue and is awaiting approval and merge. Once that is merged, change the .github/actions/setup-miniconda/action.yml file to use the official version of the action rather than my fork/branch.

Errors

I did my best to make all the jobs work, but lacking knowledge specific to this project makes it nearly impossible for me to get everything working. Someone with better knowledge of this project will need to address the errors.

The test_macos, test_linux, test_win, and test_plugin_win jobs fail with an error. The best way to view the errors is by viewing the latest workflow run in my fork. Here is the latest workflow run in my fork.


https://fburl.com/workplace/f6mz6tmw

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Tested in fork.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants