Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dockerfile #208

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Dockerfile #208

wants to merge 1 commit into from

Conversation

fqassemi
Copy link

A few files in the docker requires update including:

numpy
fsspec[http]
python-multipart

@fqassemi
Update Dockerfile
bd71d3a 
A few files in the docker requires update including:

numpy
fsspec[http]
python-multipart
@facebook-github-bot
Copy link

Hi @fqassemi!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@fqassemi
Copy link
Author

I have signed CLA with this account

This was referenced Feb 21, 2024
Open
Open
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 22, 2024
@qaiwiz qaiwiz mentioned this pull request Feb 22, 2024
Open
robertobagnato
robertobagnato reviewed Mar 20, 2024
View reviewed changes
Copy link

@robertobagnato robertobagnato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also needs 'typing-extensions>=4.9.0'
RUN pip3 install --upgrade 'typing-extensions>=4.9.0'

@fqassemi
Copy link
Author

fqassemi commented Mar 20, 2024 •
edited
Loading

It also needs 'typing-extensions>=4.9.0' RUN pip3 install --upgrade 'typing-extensions>=4.9.0'

Why is my docker without that working? Does it inherit from my env?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertobagnato robertobagnato robertobagnato left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fqassemi @facebook-github-bot @robertobagnato