Regularize handling of dense features (#1447)

Summary: Pull Request resolved: #1447 Regularize handling of dense features Differential Revision: D23502163 fbshipit-source-id: e7f4f2d635f87a6390b358d90e4d294042e9a3d5
facebookresearch · Sep 3, 2020 · 575b268 · 575b268
1 parent c9b04a5
commit 575b268
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/pytext/torchscript/module.py b/pytext/torchscript/module.py
@@ -69,12 +69,12 @@ def __init__(
     @torch.jit.script_method
     def forward(
         self,
-        dense_feat: List[List[float]],
         texts: Optional[List[str]] = None,
         # multi_texts is of shape [batch_size, num_columns]
         multi_texts: Optional[List[List[str]]] = None,
         tokens: Optional[List[List[str]]] = None,
         languages: Optional[List[str]] = None,
+        dense_feat: Optional[List[List[float]]] = None,
     ):
         inputs: ScriptBatchInput = ScriptBatchInput(
             texts=resolve_texts(texts, multi_texts),
@@ -107,13 +107,13 @@ def __init__(
     @torch.jit.script_method
     def forward(
         self,
-        right_dense_feat: List[List[float]],
-        left_dense_feat: List[List[float]],
         texts: Optional[List[str]] = None,
         # multi_texts is of shape [batch_size, num_columns]
         multi_texts: Optional[List[List[str]]] = None,
         tokens: Optional[List[List[str]]] = None,
         languages: Optional[List[str]] = None,
+        right_dense_feat: Optional[List[List[float]]] = None,
+        left_dense_feat: Optional[List[List[float]]] = None,
     ):
         inputs: ScriptBatchInput = ScriptBatchInput(
             texts=resolve_texts(texts, multi_texts),