Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Making seq2seq_model more torchscript-friendly #1459

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shreydesai
Copy link
Contributor

Summary:
seq2seq_model.py changes:

  • removes dependence on _ when unpacking the tensor dicts
  • explicit None checks on dict feats

Differential Revision: D23673319

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Sep 13, 2020
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23673319

Akshat Shrivastava and others added 2 commits September 13, 2020 20:07
Differential Revision: D23602908

fbshipit-source-id: 22c7a7eea40231de80bc651bc585749042bb33e0
Summary:
Pull Request resolved: facebookresearch#1459

seq2seq_model.py changes:
- removes dependence on _ when unpacking the tensor dicts
- explicit None checks on dict feats

Differential Revision: D23673319

fbshipit-source-id: dd0f8e164b7368a6eef7fcf02a1a15a3c078f33e
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D23673319

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants