Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix demo video downloading: Add explicit DTS/CTS in video export #431

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix demo video downloading: Add explicit DTS/CTS in video export #431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions demo/frontend/src/common/codecs/VideoEncoder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export function encode(
let encodedFrameIndex = 0;
let nextKeyFrameTimestamp = 0;
let trackID: number | null = null;
let totalDuration = 0;
const durations: number[] = [];

const outputFile = createFile();
Expand All @@ -52,9 +53,14 @@ export function encode(
}
const shiftedDuration = durations.shift();
if (shiftedDuration != null) {
const scaledDuration = getScaledDuration(shiftedDuration);
totalDuration += scaledDuration;

outputFile.addSample(trackID, uint8, {
duration: getScaledDuration(shiftedDuration),
is_sync: chunk.type === 'key',
duration: scaledDuration,
is_sync: chunk.type === 'key',
dts: totalDuration, // Add explicit DTS
cts: totalDuration, // Add explicit CTS
});
encodedFrameIndex++;
progressCallback?.(encodedFrameIndex / numFrames);
Expand Down