Aria and Perception: Aria readers, object detection on ADT, QR code detection on Aria data #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
zephirefaith
requested changes
Sep 25, 2023
KavitShah1998
force-pushed
the
vrs_mps_datastreamer
branch
from
30da18f to
6924120
Compare
KavitShah1998
force-pushed
the
vrs_mps_datastreamer
branch
from
bea756a to
78b69d2
Compare
KavitShah1998
changed the base branch from
qr_code_and_skill_manager_location_update
to
main
KavitShah1998
force-pushed
the
vrs_mps_datastreamer
branch
from
78b69d2 to
53cb2ba
Compare
KavitShah1998
force-pushed
the
april_tag_detection
branch
2 times, most recently
from
1323970 to
e546d02
Compare
KavitShah1998
force-pushed
the
vrs_mps_datastreamer
branch
from
53cb2ba to
088c48c
Compare
KavitShah1998
force-pushed
the
vrs_mps_datastreamer
branch
from
088c48c to
26e90ae
Compare
KavitShah1998
force-pushed
the
vrs_mps_datastreamer
branch
4 times, most recently
from
e5db370 to
4fb9a44
Compare
zephirefaith
changed the title
jimmytyyang
reviewed
Oct 12, 2023
aria_data_loaders/aria_data_utils/utils/april_tag_pose_estimator.py
Outdated
Show resolved
Hide resolved
rutadesai
reviewed
Oct 16, 2023
There was a problem hiding this comment.
Thanks so much, Priyam and Kavit for pushing on this! So much coming together in this PR :D I did a coarse pass and left some comments, mostly related to providing more comments for n00bs like me :) We might want to cleanup the transforms code and viz.debug components once we have all the pieces working.
aria_data_loaders/aria_data_utils/memory_interface/adt_memory_provider.py
Show resolved
Hide resolved
KavitShah1998
force-pushed
the
vrs_mps_datastreamer
branch
2 times, most recently
from
604e6b9 to
356242e
Compare
KavitShah1998
commented
Oct 26, 2023
jimmytyyang
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
LGTM! thanks for working on this
Two things we need to clean it up in the next iteration :)
- move some of codes to ROS node so that we can potentially to speed up the process
- Make sure that the newly install package like magnum does not break the existing installation guideline
aria_data_loaders/aria_data_utils/detector_wrappers/object_detector.py
Outdated
Show resolved
Hide resolved
KavitShah1998
force-pushed
the
vrs_mps_datastreamer
branch
from
7bfc1fa to
fc6e2fc
Compare
rutadesai
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
Looks so much cleaner, well documented and organized now! <3 Thanks so much for revamping this whole PR. One request -- while we have it fresh in our minds, could we add links to relevant transformations for Spot and Aria. And a quick TLDR on Aria->World, Spot->World and Aria->Spot transformation process/logic. We can do this either in docstring or in docs?
… location of interest as seen in Aria
KavitShah1998
force-pushed
the
vrs_mps_datastreamer
branch
from
edc54d7 to
53e189d
Compare
zephirefaith
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.