Feat/initial kraken setup#1
Open
arghyaiitb wants to merge 7 commits into
Open
Conversation
ntallapa12
suggested changes
Aug 31, 2019
| const logger = req.logger; | ||
| const clientId = req.query.client; | ||
| utils.setLogTokens(logger, 'videoAnalysis', 'getVideoAnalysisDetails', req.query.client, null); | ||
| let model = new VideoAnalysisModel(logger); |
There was a problem hiding this comment.
create model object outside all functions and resuse it (change it to const instead of let)
| @@ -0,0 +1,189 @@ | |||
| const VideoAnalysisModel = require('../../../models/videoAnalysis'); | |||
There was a problem hiding this comment.
all the file names should be all small separated by - between words thats the convention we follow today. rename videoAnalysis to video-analysis.js
| utils.setLogTokens(logger, 'videos', 'createVideoEntry', req.query.client, null); | ||
| const clientId = req.query.client; | ||
| let requestBody = req.body; | ||
| const schema = Joi.object().keys({ |
There was a problem hiding this comment.
Pull all entity schemas into a separate directory and import them here
| const MongoBase = require('../lib/MongoBase'); | ||
| const MongoPaging = require('mongo-cursor-pagination'); | ||
| const utils = require('../lib/utils'); | ||
| var ObjectId = require('mongodb').ObjectId; |
There was a problem hiding this comment.
have you tried const/let instead of var?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.