Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added accounting for terminal size #83

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

BjornTheProgrammer
Copy link

@BjornTheProgrammer BjornTheProgrammer commented Oct 28, 2024

Fixes #64 and #79, and is based upon work in #73, but just refined.

Adds one external API called set_size to modify the number of rows displayed at once for select and multiselect.

By default, this ensures that there are not more than the maximum possible rows displayed at once.

@fadeevab
Copy link
Owner

@BjornTheProgrammer Thanks! I'll check it out later. As of now, apply rustfmt over your changes (Alt+Shift+F in vscode), I can see TABs and some formatting inconsistencies.

@BjornTheProgrammer
Copy link
Author

Whoops, should be fixed now. I ran cargo fmt, which should be the same as VSCode's.

@BjornTheProgrammer
Copy link
Author

I realized that the test used the wrong function name, I've updated that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] issues when rendering a select whose items are longer than the active terminal viewport
2 participants