re-enable "unexpected_cfgs" lint #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faern
reviewed
May 24, 2024
Previously, this lint was disabled because it would not accept custom cfg values unless a build.rs was added (which is undesirable). Now, reachable cfgs can be configured from Cargo.toml, so this is what we should do.
simonwuelker
force-pushed
the
reenable-unexpected-cfgs-lint
branch
from
b5ab39b to
d4e22af
Compare
|
Nice. Thank you! |
|
I realize we need to make I just found https://crates.io/crates/oneshot-uniffi, and that made it even more apparent. |
|
I will explore that: #43 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34
Enables the
unexpected_cfgslint as described in #34 (comment)