Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix propagation of signal metadata by DataSink #285

Closed
frankosterfeld opened this issue Feb 23, 2024 · 1 comment
Closed

Fix propagation of signal metadata by DataSink #285

frankosterfeld opened this issue Feb 23, 2024 · 1 comment
Assignees

Comments

@frankosterfeld
Copy link
Contributor

frankosterfeld commented Feb 23, 2024

[This is part of fair-acc/opendigitizer#160 , to track graph-prototype-specific work, thus no separate SP]

Make sure that the signal metadata handling (sample_rate, signal_name, signal_unit, signal_min, signal_max) works correctly:
If the source has these properties and sends them down via tags (via the implicit propagation done for default tags), make sure they are picked up the data sink and forwarded in the respective DataSet fields (for triggered/multiplexed/snapshot) or tags (for streaming).
Make sure that property changes during runtime including signal_name are handled correctly and in a thread-safe manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant