Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2SP, 2SP] Service: Ensure signal metadata is propagated from source in the remote flowgraph via the RemoteSource to the local flowgraph #160

Closed
3 tasks
frankosterfeld opened this issue Feb 23, 2024 · 1 comment · Fixed by #164
Assignees

Comments

@frankosterfeld
Copy link
Contributor

frankosterfeld commented Feb 23, 2024

  • Make sure graph prototype correctly handles metadata, see also Fix propagation of signal metadata by DataSink gnuradio4#285
  • Make sure that metadata (sample rate, signal name, signal unit, signal min, signal max) is propagated all the way from the respective settings at the GR source block via the GR data sink to the REST payload sent by the GnuRadioWorker.
  • Ensure that metadata sent by the GnuRadioWorker service and received by RemoteSource is forwarded correctly down the line to other blocks/charts, etc.
@frankosterfeld frankosterfeld self-assigned this Feb 23, 2024
@wirew0rm wirew0rm changed the title [1SP] Service: Ensure signal metadata is propagated from source to REST payload [2SP] Service: Ensure signal metadata is propagated from source in the remote flowgraph via the RemoteSource to the local flowgraph Feb 23, 2024
@wirew0rm wirew0rm linked a pull request Feb 27, 2024 that will close this issue
@wirew0rm wirew0rm linked a pull request Feb 29, 2024 that will close this issue
@frankosterfeld
Copy link
Contributor Author

frankosterfeld commented Feb 29, 2024

#164 is ready, but depends on:

fair-acc/gnuradio4#283 (ready from my POV, open question about renaming existing init() function or state machine callback)

fair-acc/gr-digitizers#142 (code ready, but dependency needs to be updated after merge of fair-acc/gnuradio4#283)

@frankosterfeld frankosterfeld changed the title [2SP] Service: Ensure signal metadata is propagated from source in the remote flowgraph via the RemoteSource to the local flowgraph [2SP, 2SP] Service: Ensure signal metadata is propagated from source in the remote flowgraph via the RemoteSource to the local flowgraph Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA-Accepted/Merged (∞)
Development

Successfully merging a pull request may close this issue.

1 participant