Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update restyled to clang-format 18 #132

Merged
merged 1 commit into from
Apr 24, 2024
Merged

CI: update restyled to clang-format 18 #132

merged 1 commit into from
Apr 24, 2024

Conversation

wirew0rm
Copy link
Member

@wirew0rm wirew0rm commented Jul 19, 2023

update restyled to use clang-format 18. Fixed on a specific image so there will be no surprise reformatting if clang-format gets it's next release.

Also disable creating pull requests and instead only push the branch and set the status check to decrease the amount of PRs especially for Draft PRs.

Since clang-format is not yet enabled here, we could also wait with merging this until we have finalized the clang-format rules.

Depends on restyled upstream clang-format support: restyled-io/restylers#735

@wirew0rm wirew0rm temporarily deployed to configure coverage July 19, 2023 12:22 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 19, 2023 12:22 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 19, 2023 12:22 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 19, 2023 12:22 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 19, 2023 12:22 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 19, 2023 12:22 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 19, 2023 12:22 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 19, 2023 12:22 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 19, 2023 12:22 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 19, 2023 12:22 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 19, 2023 12:22 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 19, 2023 12:22 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 19, 2023 12:22 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 19, 2023 12:22 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 19, 2023 12:22 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 19, 2023 12:22 — with GitHub Actions Inactive
@RalphSteinhagen
Copy link
Member

@wirew0rm @ivan-cukic @mormj @willcode @marcusmueller We should nail down the clang-formatting rules sooner rather than later.

I initially hoped to have a community-driven, majority-voting process but this may take too much time before GrCon23 and getting this prototype as the new GR 4.0 draft in. If this is a bridge too far, we could postpone this until this repo has been migrated to the gnuradio organisation.

Maybe we could do a 2-step mini-workshop going through the clang-formatting rules?

  1. agree on the overall goals and non-goals
  2. going through the clang-format rule one-by-one and see which and whether some of these are enforced.

Similarly for the sonar[lint,cube] QA rules (but in another round, since the default is already quite reasonable IMO).

At least for my part, I do not want to discuss code formatting, spelling, or nit-picking things in PR reviews while losing track of the bigger picture aspects like architecture design, performance etc.

Your input/feedback on this would be much appreciated.

@wirew0rm wirew0rm temporarily deployed to configure coverage July 20, 2023 07:34 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 20, 2023 07:34 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 20, 2023 07:34 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 20, 2023 07:34 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 20, 2023 07:34 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 20, 2023 07:34 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 20, 2023 07:34 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 20, 2023 07:34 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 20, 2023 07:34 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 20, 2023 07:34 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 20, 2023 07:34 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage July 20, 2023 07:34 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 11, 2023 09:49 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 11, 2023 09:49 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 11, 2023 09:50 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 11, 2023 09:50 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 11, 2023 09:50 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 11, 2023 09:50 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 11, 2023 09:50 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 11, 2023 09:50 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 11, 2023 09:50 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 11, 2023 09:50 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 11, 2023 09:50 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 11, 2023 09:50 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 11, 2023 09:50 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 11, 2023 09:50 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 11, 2023 09:50 — with GitHub Actions Inactive
@wirew0rm wirew0rm temporarily deployed to configure coverage August 11, 2023 09:50 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@RalphSteinhagen
Copy link
Member

@wirew0rm and @drslebedev we should move this to clang-format18 now and settled on a common format.

As discussed earlier in #311 we should:

[ ] improved clang-format definition, needs draft for further discussions and evaluation => ACTION: Semen
focus on keeping intentional line breaks/long-lines & being vertically compact otherwise

Let's keep the ball rolling and finish this so that we can release a GR 4.0 beta0 version

@wirew0rm wirew0rm changed the title CI: update restyled to clang-format 16 CI: update restyled to clang-format 18 Apr 24, 2024
@wirew0rm
Copy link
Member Author

Updated to clang-format-18, which has a pending PR for support in restyled restyled-io/restylers#735 which usually are merged pretty quickly.

Actual clang-format configuration is a different issue and since there is no agreed upon configuration right now this has no effects since restyled is disabled on this repository.

Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wirew0rm wirew0rm marked this pull request as ready for review April 24, 2024 17:42
@wirew0rm wirew0rm merged commit a77532c into main Apr 24, 2024
8 of 9 checks passed
@wirew0rm wirew0rm deleted the restyledClang16 branch April 24, 2024 17:42
ablepharus pushed a commit to ablepharus/gnuradio4 that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants