Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to latest GR4.0-alpha #140

Merged
merged 1 commit into from
Feb 21, 2024
Merged

bump to latest GR4.0-alpha #140

merged 1 commit into from
Feb 21, 2024

Conversation

RalphSteinhagen
Copy link
Member

@RalphSteinhagen RalphSteinhagen commented Feb 20, 2024

minor fixes:

  • CircularBuffer::reserve_output_range(nSamples) -> CircularBuffer::reserve(nSamples)
  • changed/removed manual block state handling in Picoscope
  • removed superfluous ';'

EDIT:
clang/libc++ does not support the required <chrono> features to convert from TAI to UTC and std::views::enumerate. I looked into basic workarounds but this became rather ugly. Since this should be solved by itself rather soon (both things are being actively worked upon within clang/libc++), I thus disabled the timing-related blocks and unit-tests for the time being for Emscripten and Clang.

Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

sonarcloud bot commented Feb 20, 2024

@wirew0rm wirew0rm self-requested a review February 21, 2024 08:11
Copy link
Member

@wirew0rm wirew0rm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, since we don't immediately need the clang/emscripten build I think it's valid to have it disabled and hope for better libc++ support 👍

@wirew0rm wirew0rm merged commit 8b261c1 into dev-prototype Feb 21, 2024
7 checks passed
@wirew0rm wirew0rm deleted the bumpGRLatest branch February 21, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants