-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump to latest GR4.0-alpha #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
12bfad2
to
c2265f0
Compare
c2265f0
to
54e38c9
Compare
54e38c9
to
a1f07cb
Compare
a1f07cb
to
f88bfce
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good, since we don't immediately need the clang/emscripten build I think it's valid to have it disabled and hope for better libc++ support 👍
minor fixes:
CircularBuffer::reserve_output_range(nSamples)
->CircularBuffer::reserve(nSamples)
EDIT:
clang/libc++ does not support the required
<chrono>
features to convert from TAI to UTC andstd::views::enumerate
. I looked into basic workarounds but this became rather ugly. Since this should be solved by itself rather soon (both things are being actively worked upon within clang/libc++), I thus disabled the timing-related blocks and unit-tests for the time being for Emscripten and Clang.