-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: one folder build option for packaging SODA #374
base: pre-staging
Are you sure you want to change the base?
Conversation
Thank you for submitting this pull request! We appreciate your contribution to the project. Before we can merge it, we need to review the changes you've made to ensure they align with our code standards and meet the requirements of the project. We'll get back to you as soon as we can with feedback. Thanks again! |
Reviewer's Guide by SourceryThis PR implements a one-folder build option for packaging SODA by modifying the build and deployment scripts. The changes switch from using PyInstaller's --onefile to --onedir option, updates version numbers, and adjusts build configurations. The implementation also includes workflow updates and minor code changes. Updated class diagram for package.json scriptsclassDiagram
class PackageJson {
+String name
+String productName
+String version
+String description
+String main
+String author
+String[] scripts
}
class Scripts {
+String build:linux
+String python-onefile-build-win
+String python-onefile-build-unix
+String python-folder-build-unix
+String python-folder-build-win
+String deploy-win
+String deploy-linux
+String deploy-mac
}
PackageJson --> Scripts
note for Scripts "Updated to include folder build options and deployment changes"
Updated class diagram for electron-builder.ymlclassDiagram
class ElectronBuilderYml {
+String winExtraResources
+Boolean asar
+String[] target
+String macIcon
+String macEntitlementsInherit
+Boolean macNotarize
+String[] macExtraResources
}
note for ElectronBuilderYml "Updated macNotarize to false and winExtraResources path"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Thanks for making updates to your pull request. Our team will take a look and provide feedback as soon as possible. Please wait for any GitHub Actions to complete before editing your pull request. If you have any additional questions or concerns, feel free to let us know. Thank you for your contributions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aaronm-2112 - I've reviewed your changes - here's some feedback:
Overall Comments:
- There appears to be debug code left in (console.log in renderer.js) that should be removed
- The PR disables Mac notarization without explanation. Please provide context for this security-relevant change
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟡 Security: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -31,7 +31,7 @@ nsis: | |||
mac: | |||
icon: "app-icon/png/icon.png" | |||
entitlementsInherit: ./entitlements.mac.inherit.plist | |||
notarize: true | |||
notarize: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 issue (security): Disabling Mac notarization could cause security warnings for users
Consider the security implications of disabling notarization. Users may receive warnings when running the application, potentially affecting trust and usability.
package.json
Outdated
@@ -1,7 +1,7 @@ | |||
{ | |||
"name": "soda-for-sparc", | |||
"procductName": "SODA for SPARC", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (typo): Fix typo in 'productName' field
Quality Gate passedIssues Measures |
Summary by Sourcery
Add a new one-folder build option for packaging SODA, update the application version, and modify CI workflows to include the 'folder-build' branch.
New Features:
Enhancements:
CI: