fix(agent): log exception instead of returning (revert #121) #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
force-pushed
the
ruslan/fea-2353-better-error-messages-handle-internal-errors-gracefully
branch
5 times, most recently
from
01b7a08 to
c2764c2
Compare
efiop
changed the title
efiop
changed the title
We stopped always yielding stuff unconditionally, so now if you get an error and use our own `abort_with_msg` we'll get an error iterating responses, as we never yield anything and just return `None`. So instead just use proper grpc `ServicerContext.abort()` method to raise an exception instead.
We need to keep backward compatibility with older clients and they will have trouble unpickling a new exception, as we are sending these out pickled by reference and not by value (solving that would require serialization backend specific actions, which I would rather avoid for now to unblock a release).
efiop
force-pushed
the
ruslan/fea-2353-better-error-messages-handle-internal-errors-gracefully
branch
3 times, most recently
from
dfb83dc to
a94fd5a
Compare
efiop
changed the title
efiop
deleted the
ruslan/fea-2353-better-error-messages-handle-internal-errors-gracefully
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to keep backward compatibility with older clients and they will have trouble unpickling a new exception, as we are sending these out pickled by reference and not by value (solving that would require serialization backend specific actions, which I would rather avoid for now to unblock a release).