chore(grpc): print agent logs in addition to sending over grpc, v2 #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional note about why this will work with old applications (since this is not super trivial): we build multiple environments in server itself with the first one being an agent environment that uses requirements that we pass to it in
AGENT_REQUIREMENTS_TXT, and this one is built no matter what application you are running and what requirements it might have. Then when spawning an agent and running user code in it, the environment they are running in has a chain ofPYTHONPATHs that are inherited in an order that makes the first one (so the one from agent requirements txt) override anything after that, which means that no matter what user apps we are running our agent requirements will be the ones uses (including isolate), which makes this PR possible without breaking backward compatibility.Reapplying #133