Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(pkg/driverbuilder): added a node selector for kubernetes executor's pod on kubernetes.io/arch label #327

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

FedeDP
Copy link
Contributor

@FedeDP FedeDP commented Mar 26, 2024

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area pkg

What this PR does / why we need it:

This implements support for arm64 build for kubernetes executor.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

…on `kubernetes.io/arch` label.

This implements support for arm64 build for kubernetes executor.

Signed-off-by: Federico Di Pierro <[email protected]>
@FedeDP
Copy link
Contributor Author

FedeDP commented Mar 26, 2024

/cc @Lowaiz

@poiana poiana added the size/XS label Mar 26, 2024
@poiana poiana requested a review from Lowaiz March 26, 2024 10:26
@FedeDP
Copy link
Contributor Author

FedeDP commented Mar 26, 2024

/hold

@FedeDP FedeDP changed the title new(pkg/driverbuilder): added a node selector on kubernetes executor on kubernetes.io/arch label new(pkg/driverbuilder): added a node selector for kubernetes executor's pod on kubernetes.io/arch label Mar 26, 2024
@FedeDP
Copy link
Contributor Author

FedeDP commented Mar 27, 2024

Tested that this works fine against an amd64 build on a local kind cluster.
This means that the nodeSelector is working fine, and i expect it to work fine against arm64 too.

@FedeDP
Copy link
Contributor Author

FedeDP commented Mar 28, 2024

/unhold

Copy link
Contributor

@EXONER4TED EXONER4TED left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link

poiana commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EXONER4TED, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit c12a122 into master Mar 28, 2024
5 checks passed
@poiana poiana deleted the chore/add_node_selector_arm branch March 28, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants