-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(docs): update getting started pages #1333
new(docs): update getting started pages #1333
Conversation
eff2bc8
to
a5d0600
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @LucaGuerra 👏
I left a few suggestions (just nitpicking 👼 ), but overall I love the new shape of the getting started section.
Let me know when you remove the "WIP", and I will give a second look
🙏
b87fd1a
to
144c512
Compare
Signed-off-by: Luca Guerra <[email protected]>
Co-authored-by: Leonardo Grasso <[email protected]> Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
Signed-off-by: Luca Guerra <[email protected]>
144c512
to
70f801a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just found a typo (now fixed), otherwise LGTM.
@Issif wdyt?
Signed-off-by: Leonardo Grasso <[email protected]>
Signed-off-by: Leonardo Grasso <[email protected]>
LGTM label has been added. Git tree hash: 06e56704098c29f142d0888cd1851d43c0c2bccd
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leogr, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind content
Any specific area of the project related to this PR?
/area documentation
What this PR does / why we need it:
Lately we have worked a lot to improve Falco's installation experience and remove some manual configuration that you had to specify the first time you used it. I believe it's time to make this work shine in the "Getting Started" page. Instead of relying on reproducible environments that however would require you to have VirtualBox or other similar things installed, I would propose offering the simplest commands to start Falco, along with a quick path to see your first event and write your first rule.
I don't think, however, that the guide that uses VirtualBox should be entirely thrown away but it's not the first one that we should suggest IMO.
This PR is here to discuss if we agree with that, and then I can complete the missing parts and/or we can proceed adding other sections
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: