Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Policy report link #1336

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix Policy report link #1336

merged 1 commit into from
Jul 24, 2024

Conversation

nlamirault
Copy link
Contributor

@nlamirault nlamirault commented Jul 5, 2024

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Nicolas Lamirault <[email protected]>
@poiana
Copy link

poiana commented Jul 5, 2024

Welcome @nlamirault! It looks like this is your first PR to falcosecurity/falco-website 🎉

@poiana poiana requested review from mstemm and vjjmiras July 5, 2024 12:43
@poiana poiana added the size/XS label Jul 5, 2024
Copy link
Member

@Issif Issif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch. could you also add the new outputs from falcosidekick 2.29?

  • Dynatrace
  • Sumologic
  • OTLP Traces
  • Talon

@leogr
Copy link
Member

leogr commented Jul 11, 2024

nice catch. could you also add the new outputs from falcosidekick 2.29?

  • Dynatrace
  • Sumologic
  • OTLP Traces
  • Talon

@Issif May we postpone those additions to a follow-up PR? 🤔

@Issif
Copy link
Member

Issif commented Jul 11, 2024

nice catch. could you also add the new outputs from falcosidekick 2.29?

  • Dynatrace
  • Sumologic
  • OTLP Traces
  • Talon

@Issif May we postpone those additions to a follow-up PR? 🤔

Without any answer from @nlamirault before end of the next week, I'll merge this PR and create another one.

@leogr
Copy link
Member

leogr commented Jul 24, 2024

nice catch. could you also add the new outputs from falcosidekick 2.29?

  • Dynatrace
  • Sumologic
  • OTLP Traces
  • Talon

@Issif May we postpone those additions to a follow-up PR? 🤔

Without any answer from @nlamirault before end of the next week, I'll merge this PR and create another one.

@Issif pls open another PR. I'm approving this meanwhile. Thanks

@poiana
Copy link

poiana commented Jul 24, 2024

LGTM label has been added.

Git tree hash: 4145e1df85dcef48ab28b5877d0d40f5cb7b482a

@poiana
Copy link

poiana commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leogr, nlamirault

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit e0f15da into falcosecurity:master Jul 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants