fix(userspace/falco): use resolved plugin name when opening a plugin #2926
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Previously, to enable a plugin users needed to know the plugin name, ie: the name exposed by the
plugin_get_name
plugin API.Now, we automatically use the plugin name internally, while externally we satisfy the name given by the user in the
plugins
section.Basically, user can now write:
And getting its dummyFOO plugin loaded correctly, while previously we would've failed, unless the
load_plugins
contained the real plugin name (in this casedummy
).From a UX PoV, i think the user shall know nothing about real plugin name; she/he should just have the
.so
of the plugin to be loaded and use the desired name in the config (like, in the example above,dummyFOO
).Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: