Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(falco): print system info when Falco starts #2927

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area engine

What this PR does / why we need it:

This PR helps maintainers in triaging issues and users in reporting effective info on issues. The idea is to print the content of /proc/version in the Falco startup messages @FedeDP

Mon Nov 27 15:48:06 2023: Falco version: 0.37.0-155+6095d10 (x86_64)
Mon Nov 27 15:48:06 2023: Falco initialized with configuration file: ../falco.yaml
Mon Nov 27 15:48:06 2023: System info: Linux version 6.2.0-37-generic (buildd@bos03-amd64-055) (x86_64-linux-gnu-gcc-11 (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0, GNU ld (GNU Binutils for Ubuntu) 2.38) #38~22.04.1-Ubuntu SMP PREEMPT_DYNAMIC Thu Nov  2 18:01:13 UTC 2
Mon Nov 27 15:48:06 2023: Loading rules from file ../rules/falco_rules.yaml
Mon Nov 27 15:48:06 2023: The chosen syscall buffer dimension is: 8388608 bytes (8 MBs)
Mon Nov 27 15:48:06 2023: Starting health webserver with threadiness 8, listening on 0.0.0.0:8765
Mon Nov 27 15:48:06 2023: Loaded event sources: syscall
Mon Nov 27 15:48:06 2023: Enabled event sources: syscall
Mon Nov 27 15:48:06 2023: Opening 'syscall' source with BPF probe. BPF probe path: /root/.falco/falco-bpf.o

In case we are not able to read under /proc/version we provide a log but we don't fail

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

new(falco): print system info when Falco starts

Print kernel info when Falco starts with a kernel driver

Signed-off-by: Andrea Terzolo <[email protected]>
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! It will make debugging driver related issues a little better!
/approve

@poiana
Copy link
Contributor

poiana commented Nov 27, 2023

LGTM label has been added.

Git tree hash: 84a781ae983938e4e77358da50be471a90f8e0ee

Copy link
Contributor

@incertum incertum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, incertum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Andreagit97,FedeDP,incertum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit c5364be into falcosecurity:master Nov 28, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants