Skip to content

chore(ci): build Falco in RelWithDebInfo, and upload Falco debug symbols as github artifacts #3452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poiana merged 2 commits into from
Jan 16, 2025
Merged

chore(ci): build Falco in RelWithDebInfo, and upload Falco debug symbols as github artifacts #3452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baefaaf
chore(ci): build Falco in RelWithDebInfo, and upload Falco debug symb…
FedeDP Jan 16, 2025
bd80885
fix(ci): fixed Falco release debug symbols names.
FedeDP Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,9 +160,28 @@ jobs:
echo "" >> release-body.md
echo "#### Release Manager @${{ github.event.release.author.login }}" >> release-body.md

- name: Download debug symbols for Falco x86_64
uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
with:
name: falco-${{ github.event.release.tag_name }}-x86_64.debug

- name: Rename x86_64 debug symbols
run: mv falco.debug falco-x86_64.debug

- name: Download debug symbols for Falco aarch64
uses: actions/download-artifact@9bc31d5ccc31df68ecc42ccf4149144866c47d8a # v3.0.2
with:
name: falco-${{ github.event.release.tag_name }}-aarch64.debug

- name: Rename aarch64 debug symbols
run: mv falco.debug falco-aarch64.debug

- name: Release
uses: softprops/action-gh-release@de2c0eb89ae2a093876385947365aca7b0e5f844 # v0.1.15
with:
body_path: ./release-body.md
tag_name: ${{ github.event.release.tag_name }}
name: ${{ github.event.release.name }}
files: |
falco-x86_64.debug
falco-aarch64.debug
Comment thread
LucaGuerra marked this conversation as resolved.
11 changes: 9 additions & 2 deletions .github/workflows/reusable_build_packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
- name: Prepare project
run: |
cmake -B build -S . \
-DCMAKE_BUILD_TYPE=Release \
-DCMAKE_BUILD_TYPE=RelWithDebInfo \
-DUSE_BUNDLED_DEPS=On \
-DFALCO_ETC_DIR=/etc/falco \
-DMODERN_BPF_SKEL_DIR=/tmp \
Expand Down Expand Up @@ -113,7 +113,14 @@ jobs:
with:
name: falco-${{ inputs.version }}-${{ inputs.arch }}.rpm
path: |
${{ github.workspace }}/build/falco-*.rpm
${{ github.workspace }}/build/falco-*.rpm

- name: Upload Falco debug symbols
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
with:
name: falco-${{ inputs.version }}-${{ inputs.arch }}.debug
path: |
${{ github.workspace }}/build/userspace/falco/falco.debug

build-packages-debug:
# See https://github.com/actions/runner/issues/409#issuecomment-1158849936
Expand Down