-
Notifications
You must be signed in to change notification settings - Fork 958
feat(engine): emit warning when a rule output uses deprecated "evt.dir" #3697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(engine): emit warning when a rule output uses deprecated "evt.dir" #3697
Conversation
Emit a warning when a rule uses the deprecated "evt.dir" field in output. Signed-off-by: Iacopo Rozzo <[email protected]>
|
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
|
ref: #3690 |
|
LGTM label has been added. Git tree hash: 820d5f8c3f1036333002106bcb23dd81faa29d2a
|
false positive |
|
/milestone 0.42.0 |
ekoops
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, irozzo-1A The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
Any specific area of the project related to this PR?
/area engine
What this PR does / why we need it:
Emit a warning when a rule uses the deprecated "evt.dir" field in output.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: