Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new: introduce asset artifact type #309

Merged
merged 13 commits into from
Dec 13, 2023
Merged

new: introduce asset artifact type #309

merged 13 commits into from
Dec 13, 2023

Conversation

loresuso
Copy link
Member

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

/kind flaky-test

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area library

/area cli

/area tests

/area examples

What this PR does / why we need it:
This PR aims at introducing a new artifact type that falcoctl can handle named asset.
This kind of artifact is something that can either be consumed by Falco plugins or Falco itself but it's neither a plugin nor a rulesfile.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@poiana poiana requested review from alacuku and cpanato July 27, 2023 08:30
@poiana poiana added the size/M label Jul 27, 2023
@loresuso loresuso force-pushed the new/plugin-artifact branch 2 times, most recently from 0e7e724 to cec33fa Compare July 27, 2023 09:27
FedeDP
FedeDP reviewed Jul 27, 2023
View reviewed changes
pkg/oci/pusher/pusher.go Outdated Show resolved Hide resolved
@poiana poiana added size/L and removed size/M labels Jul 31, 2023
@loresuso loresuso force-pushed the new/plugin-artifact branch 2 times, most recently from 0493208 to 8eb9184 Compare July 31, 2023 15:35
@poiana poiana added size/XL and removed size/L labels Aug 1, 2023
@loresuso loresuso force-pushed the new/plugin-artifact branch 3 times, most recently from 566024f to e971d85 Compare August 2, 2023 08:17
@loresuso
Copy link
Member Author

loresuso commented Aug 2, 2023

cc @alacuku

alacuku
alacuku reviewed Aug 3, 2023
View reviewed changes
Copy link
Member

@alacuku alacuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @loresuso, thanks for the PR.

Left some comments.

pkg/options/directory_options.go Outdated Show resolved Hide resolved
internal/utils/compress.go Show resolved Hide resolved
internal/utils/extract.go Outdated Show resolved Hide resolved
@poiana
Copy link
Contributor

poiana commented Nov 2, 2023

Issues go stale after 90d of inactivity.

Mark the issue as fresh with /remove-lifecycle stale.

Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Provide feedback via https://github.com/falcosecurity/community.

/lifecycle stale

@loresuso
Copy link
Member Author

loresuso commented Nov 2, 2023

/remove-lifecycle stale

@leogr
Copy link
Member

leogr commented Dec 12, 2023

@loresuso can you rebase this PR, please?

@loresuso
Copy link
Member Author

loresuso commented Dec 12, 2023 •
edited
Loading

@leogr the conflict involves also the new driver logic, I'm trying to figure how to deal with that. I am probably dropping the logic checking for artifact type in extract function, maybe we don't need that check that much

loresuso and others added 12 commits December 13, 2023 11:27
@loresuso
new: introduce asset as new artifact type
0094d20 
Signed-off-by: Lorenzo Susini <[email protected]>
@loresuso
update: handle pushing and pulling of assets
9327ea2 
Signed-off-by: Lorenzo Susini <[email protected]>
@loresuso
update: adapt flag description to include asset
a40da37 
Signed-off-by: Lorenzo Susini <[email protected]>
@loresuso
update: adapt push tests
6f750ff 
Signed-off-by: Lorenzo Susini <[email protected]>
@loresuso
update: properly handle assets dir when installing assets
818c437 
Signed-off-by: Lorenzo Susini <[email protected]>
@loresuso @FedeDP
update: explicitly handle artifact types when pushing
d3a6532 
Co-authored-by: Federico Di Pierro <[email protected]>
Signed-off-by: Lorenzo Susini <[email protected]>
@loresuso
test: introduce test for asset artifact type
10ba01a 
Signed-off-by: Lorenzo Susini <[email protected]>
@loresuso
update: allow to create tar.gz from directories, required for asset t…
619150b 
…ypes

Signed-off-by: Lorenzo Susini <[email protected]>
@loresuso
update: allow to extract directories for asset files
f483277 
Signed-off-by: Lorenzo Susini <[email protected]>
@loresuso
update: satisfy new license and fix linting error
c0d776f 
Signed-off-by: Lorenzo Susini <[email protected]>
@loresuso
fix: ensure files are places in their directories when creating tar.g…
5df4a99 
…z archives

Signed-off-by: Lorenzo Susini <[email protected]>
@loresuso
test: compressing of files and dirs
7cc530f 
Signed-off-by: Lorenzo Susini <[email protected]>
FedeDP
FedeDP reviewed Dec 13, 2023
View reviewed changes
pkg/driver/distro/distro.go Outdated Show resolved Hide resolved
FedeDP
FedeDP reviewed Dec 13, 2023
View reviewed changes
internal/utils/extract.go Outdated Show resolved Hide resolved
@FedeDP
Copy link
Contributor

FedeDP commented Dec 13, 2023

/milestone v0.7.0

@poiana poiana added this to the v0.7.0 milestone Dec 13, 2023
FedeDP
FedeDP approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Dec 13, 2023
@poiana
Copy link
Contributor

poiana commented Dec 13, 2023

LGTM label has been added.

Git tree hash: d3cfb66eee3a21bea1fe69542303d8428ef0f5b6

@poiana
Copy link
Contributor

poiana commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: FedeDP, loresuso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit cda38ca into falcosecurity:main Dec 13, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alacuku alacuku alacuku left review comments

@FedeDP FedeDP FedeDP approved these changes

@cpanato cpanato Awaiting requested review from cpanato

Assignees

@leogr leogr

@FedeDP FedeDP

@alacuku alacuku

@loresuso loresuso

Labels
approved area/cli area/library dco-signoff: yes kind/feature lgtm size/XL
Projects
Falco Roadmap
Archived in project
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@loresuso @poiana @leogr @FedeDP @alacuku