feat(cmd/registry/auth/basic): allow to specify credentials as cli flags #314
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maxgio92 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @maxgio92, that's correct the issue is about the The linter is complaining, could you have a look and let me know when it's ready for review? |
Signed-off-by: Massimiliano Giovagnoli <[email protected]>
|
Hey @alacuku, sorry for my late response, I missed it. The PR is now ready |
| return err | ||
| } | ||
| o.Printer.Verbosef("credentials added to credential store") | ||
| o.Printer.Success.Println("Login succeeded") | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (o *loginOptions) ensureCredentials() error { |
There was a problem hiding this comment.
Could we support the use case where the username is given on the command line flag and the password from stdin?
|
Issues go stale after 90d of inactivity. Mark the issue as fresh with Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh with Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with Provide feedback via https://github.com/falcosecurity/community. /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue with Mark the issue as fresh with Provide feedback via https://github.com/falcosecurity/community. |
|
@poiana: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/reopen |
|
@FedeDP: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hey @maxgio92 Any update on this? I guess the PR needs to be rebased and also we should address this comment #314 (review) |
|
#588 supersedes this pr. |
|
@alacuku: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thank you @alacuku, my bad. |
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area cli
What this PR does / why we need it:
Introduces credentials CLI flags for the registry basic HTTP authentication.
Which issue(s) this PR fixes:
Fixes #134
Special notes for your reviewer:
NA