fix(cmd): relax file perms for Falco driver config override #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leogr
force-pushed
the
fix/etc-file-perm
branch
3 times, most recently
from
cd0d1d1
to
91e981f
Compare
Falco config files are not supposed to contain sensitive information, so read permissions are given to all users. With this fix, the permissions of the config file for the driver engine override will be aligned to other Falco configs files under `/etc/falco`. Signed-off-by: Leonardo Grasso <[email protected]>
leogr
force-pushed
the
fix/etc-file-perm
branch
from
91e981f
to
8f546f4
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alacuku, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
Any specific area of the project related to this PR?
/area cli
What this PR does / why we need it:
Falco config files are not supposed to contain sensitive information, so read permissions are given to all users. With this fix, the permissions of the config file for the driver engine override will be aligned to other Falco configs files under
/etc/falco.Which issue(s) this PR fixes:
The issue was discovered with falcoctl 0.10, which is bundled with Falco 0.39
Special notes for your reviewer:
cc @alacuku