Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/missing templated fields loki prometheus + log line value format for Loki #1091

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

Issif
Copy link
Member

@Issif Issif commented Jan 17, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area build

/area config

/area outputs

/area tests

What this PR does / why we need it:

The templated fields were not included a labels in loki/prometheus outputs.

A new option for Loki to change the format of the value in the log lines: text or json.

image

Which issue(s) this PR fixes:

#1090

Fixes #

Special notes for your reviewer:

@Issif Issif added this to the 2.31 milestone Jan 17, 2025
@poiana poiana added kind/bug Something isn't working dco-signoff: yes kind/feature New feature or request area/outputs labels Jan 17, 2025
@poiana poiana requested review from fjogeleit and leogr January 17, 2025 15:32
@Issif Issif changed the title Fix/missing templated fields loki prometheus WIP: Fix/missing templated fields loki prometheus Jan 17, 2025
@Issif Issif changed the title WIP: Fix/missing templated fields loki prometheus WIP: Fix/missing templated fields loki prometheus + log line value format for Loki Jan 17, 2025
@Issif Issif changed the title WIP: Fix/missing templated fields loki prometheus + log line value format for Loki Fix/missing templated fields loki prometheus + log line value format for Loki Jan 17, 2025
@Issif Issif force-pushed the fix/missing-templated-fields-loki-prometheus branch from 5db2904 to fc77c43 Compare January 27, 2025 14:24
@poiana poiana added the lgtm label Jan 27, 2025
@poiana
Copy link

poiana commented Jan 27, 2025

LGTM label has been added.

Git tree hash: fc567e4e5424e19c69c6f39678c6153fb4165497

@poiana
Copy link

poiana commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, Issif

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 82c2465 into master Jan 27, 2025
5 checks passed
@poiana poiana deleted the fix/missing-templated-fields-loki-prometheus branch January 27, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants