Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] tmp fix driver CI #2254

Closed
wants to merge 8 commits into from
Closed

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

FedeDP and others added 7 commits January 22, 2025 15:32
… is hotplugged.

Signed-off-by: Federico Di Pierro <[email protected]>

Co-authored-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
Signed-off-by: Andrea Terzolo <[email protected]>
@poiana
Copy link
Contributor

poiana commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.16%. Comparing base (6c46ed3) to head (d84e2e7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2254   +/-   ##
=======================================
  Coverage   75.16%   75.16%           
=======================================
  Files         278      278           
  Lines       34478    34478           
  Branches     5922     5923    +1     
=======================================
  Hits        25916    25916           
  Misses       8562     8562           
Flag Coverage Δ
libsinsp 75.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 23, 2025

Perf diff from master - unit tests

    10.74%     -0.97%  [.] sinsp_parser::reset
     5.30%     +0.71%  [.] next_event_from_file
     1.14%     +0.63%  [.] libsinsp::sinsp_suppress::process_event
     3.80%     -0.49%  [.] sinsp_evt::load_params
     8.16%     -0.39%  [.] sinsp_evt::get_type
     0.80%     -0.22%  [.] std::vector<sinsp_evt_param, std::allocator<sinsp_evt_param> >::emplace_back<sinsp_evt*, unsigned int&, char const*, unsigned long&>
     1.18%     -0.21%  [.] sinsp_parser::event_cleanup
     0.82%     -0.18%  [.] sinsp_parser::parse_context_switch
     0.67%     +0.17%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char*>
     0.86%     -0.17%  [.] libsinsp::events::is_unknown_event

Heap diff from master - unit tests

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0118         +0.0118           144           146           144           146
BM_sinsp_split_median                                          +0.0178         +0.0178           144           147           144           147
BM_sinsp_split_stddev                                          +0.5311         +0.5297             1             1             1             1
BM_sinsp_split_cv                                              +0.5132         +0.5118             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  -0.0136         -0.0136            57            56            57            56
BM_sinsp_concatenate_paths_relative_path_median                -0.0140         -0.0140            57            56            57            56
BM_sinsp_concatenate_paths_relative_path_stddev                -0.0836         -0.0818             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_cv                    -0.0710         -0.0692             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0311         -0.0311            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_median                   -0.0286         -0.0286            25            24            25            24
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.8103         -0.8112             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.8042         -0.8051             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  +0.0034         +0.0034            56            56            56            56
BM_sinsp_concatenate_paths_absolute_path_median                +0.0024         +0.0024            56            56            56            56
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.1857         +0.1850             0             1             0             1
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.1816         +0.1810             0             0             0             0
BM_sinsp_split_container_image_mean                            -0.0140         -0.0140           389           383           389           383
BM_sinsp_split_container_image_median                          -0.0140         -0.0140           389           383           389           383
BM_sinsp_split_container_image_stddev                          -0.0108         -0.0104             3             3             3             3
BM_sinsp_split_container_image_cv                              +0.0033         +0.0036             0             0             0             0

@Andreagit97 Andreagit97 force-pushed the Andreagit97/fix_hotplug_2 branch from 4702932 to 3084f77 Compare January 23, 2025 08:44
Copy link

github-actions bot commented Jan 23, 2025

X64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-4.19 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2-5.10 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
amazonlinux2023-6.1 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.0 🟢 🟢 🟢 🟢 🟢 🟢
archlinux-6.7 🟢 🟢 🟢 🟢 🟢 🟢
centos-3.10 🟢 🟡 🟡 🟡
centos-4.18 🟢 🟢 🟢 🟢 🟢 🟢
centos-5.14 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.17 🟢 🟢 🟢 🟢 🟢 🟢
fedora-5.8 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-3.10 🟢 🟡 🟡 🟡
oraclelinux-4.14 🟢 🟢 🟢 🟢 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢
oraclelinux-5.4 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-4.15 🟢 🟢 🟢 🟢 🟡
ubuntu-5.8 🟢 🟢 🟢 🟢 🟢 🟡
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

ARM64 kernel testing matrix

KERNEL CMAKE-CONFIGURE KMOD BUILD KMOD SCAP-OPEN BPF-PROBE BUILD BPF-PROBE SCAP-OPEN MODERN-BPF SCAP-OPEN
amazonlinux2-5.4 🟢 🟢 🟢 🟢 🟢 🟡
amazonlinux2022-5.15 🟢 🟢 🟢 🟢 🟢 🟢
fedora-6.2 🟢 🟢 🟢 🟢 🟢 🟢
oraclelinux-4.14 🟢 🟢 🟢 🟡 🟡 🟡
oraclelinux-5.15 🟢 🟢 🟢 🟢
ubuntu-6.5 🟢 🟢 🟢 🟢 🟢 🟢

Copy link

Please double check driver/SCHEMA_VERSION file. See versioning.

/hold

Signed-off-by: Andrea Terzolo <[email protected]>
@Andreagit97 Andreagit97 force-pushed the Andreagit97/fix_hotplug_2 branch from 3084f77 to d84e2e7 Compare January 23, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants