Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add k8smeta plugin to the plugin repo #378

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Add k8smeta plugin to the plugin repo #378

merged 6 commits into from
Dec 18, 2023

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area plugins

What this PR does / why we need it:

This PR adds the k8smeta plugin to the plugin repo.

Which issue(s) this PR fixes:

Special notes for your reviewer:

@poiana poiana requested review from leogr and mstemm December 1, 2023 16:08
@Andreagit97 Andreagit97 marked this pull request as draft December 1, 2023 16:08
@poiana poiana added the size/XXL label Dec 1, 2023
@Andreagit97 Andreagit97 marked this pull request as ready for review December 1, 2023 16:09
@Andreagit97
Copy link
Member Author

This PR is still a draft but i need the CI to check the integration of the plugin, so i cannot mark it as a draft

@Andreagit97
Copy link
Member Author

The plugin repo could be another great candidate for falcosecurity/falco#2945, since from now for the k8smeta plugin we will build grpc on QEMU for arm64 :/ it takes almost 1h and 33 m

@Andreagit97
Copy link
Member Author

I have disabled codeQL for cpp in the "general" CI job, probably i will add a specific codeQL job for the k8smeta plugin and the dummy_c one

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Rules files suggestions

@Andreagit97 Andreagit97 force-pushed the add_k8s_meta_plugin branch 3 times, most recently from 665a254 to 52063e0 Compare December 6, 2023 17:33
@Andreagit97
Copy link
Member Author

Andreagit97 commented Dec 6, 2023 •
edited
Loading

I will split the actual cpp codeQL workflow into single plugin jobs for k8smeta and dummy_c

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023

Rules files suggestions

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 6, 2023
View reviewed changes
plugins/k8smeta/src/plugin.cpp Fixed Show resolved Hide resolved
@Andreagit97 Andreagit97 mentioned this pull request Dec 11, 2023
Merged
@github-actions GitHub Actions
Copy link

Rules files suggestions

@Andreagit97 Andreagit97 force-pushed the add_k8s_meta_plugin branch 2 times, most recently from 1afb9ed to 3428222 Compare December 11, 2023 19:20
@github-actions GitHub Actions
Copy link

Rules files suggestions

@github-actions GitHub Actions
Copy link

Rules files suggestions

@github-actions GitHub Actions
Copy link

Rules files suggestions

@Andreagit97 Andreagit97 changed the title [WIP]: Add k8smeta plugin to the plugin repo Add k8smeta plugin to the plugin repo Dec 12, 2023
incertum
incertum reviewed Dec 14, 2023
View reviewed changes
plugins/k8smeta/README.md Outdated Show resolved Hide resolved
@leogr
Copy link
Member

leogr commented Dec 15, 2023

/assign

@leogr leogr mentioned this pull request Dec 15, 2023
Closed
leogr
leogr reviewed Dec 15, 2023
View reviewed changes
Copy link
Member

@leogr leogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just

  • k8sres 👉 k8smeta
  • .*id 👉 *.uid

otherwise SGTM! 👏

plugins/k8smeta/README.md Outdated Show resolved Hide resolved
plugins/k8smeta/src/plugin.h Outdated Show resolved Hide resolved
Andreagit97 and others added 3 commits December 15, 2023 17:55
@Andreagit97 @incertum
cleanup(k8smeta): rename k8sres.* into k8smeta.*
0a1bae8 
Signed-off-by: Andrea Terzolo <[email protected]>
Co-authored-by: Melissa Kilby <[email protected]>
@Andreagit97 @incertum
cleanup: rename .id into .uid
1cc7159 
Signed-off-by: Andrea Terzolo <[email protected]>
Co-authored-by: Melissa Kilby <[email protected]>
@Andreagit97
cleanup: fix clang-format issues
c199272 
Signed-off-by: Andrea Terzolo <[email protected]>
@github-actions GitHub Actions
Copy link

Rules files suggestions

@poiana poiana added the lgtm label Dec 18, 2023
@poiana
Copy link
Contributor

poiana commented Dec 18, 2023

LGTM label has been added.

Git tree hash: 50f7993b0ba7253900afade5f6b9b139aa9c2de4

@poiana
Copy link
Contributor

poiana commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, leogr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 21eaf33 into falcosecurity:master Dec 18, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alacuku alacuku alacuku left review comments

@incertum incertum incertum left review comments

@leogr leogr leogr approved these changes

@mstemm mstemm Awaiting requested review from mstemm

@jasondellaluce jasondellaluce Awaiting requested review from jasondellaluce

Assignees

@leogr leogr

Labels
approved area/plugins dco-signoff: yes kind/feature New feature or request lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Andreagit97 @leogr @poiana @alacuku @incertum