fix: Allow syncTrie to handle names that are substrings

[sanjayprabhu]

Motivation

Fixes #1507. Makes all fnames unique by zero padding them.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

• PR title adheres to the conventional commits standard
• PR has a changeset
• PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore)
• PR includes documentation if necessary.
• All commits have been signed

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers

---

PR-Codex overview

Detailed summary

• Added a new migration 5.fnameSyncIds to remove unpadded fname sync ids from the sync trie.
• Updated the SyncId class to pad the name with null bytes to ensure all names have the same length.
• Updated the validateFname function to use the USERNAME_MAX_LENGTH constant.
• Added tests for handling names that are substrings of each other and names that end with 0.
• Added a test for the fnameSyncIds migration to delete unpadded fname sync ids.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[changeset-bot]

🦋 Changeset detected

Latest commit: f4d3765

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@farcaster/core	Patch
@farcaster/hubble	Patch
@farcaster/hub-nodejs	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hub-monorepo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 26, 2023 9:20pm

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
...pps/hubble/src/storage/db/migrations/migrations.ts	90.47% <100.00%> (+1.00%)	⬆️
packages/core/src/validations.ts	87.40% <100.00%> (+0.03%)	⬆️
apps/hubble/src/network/sync/syncId.ts	92.40% <88.88%> (-0.46%)	⬇️
...hubble/src/storage/db/migrations/5.fnameSyncIds.ts	92.30% <92.30%> (ø)

... and 4 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.