fix(validator): catch dangling children references in validateStructure#142
Open
CryptoExplor wants to merge 1 commit intofarcasterxyz:mainfrom
Open
fix(validator): catch dangling children references in validateStructure#142CryptoExplor wants to merge 1 commit intofarcasterxyz:mainfrom
CryptoExplor wants to merge 1 commit intofarcasterxyz:mainfrom
Conversation
Fixes farcasterxyz#136 Adds a pass inside `validateStructure` that checks every element's `children` array against the keys of `ui.elements`. If a child ID is referenced but not defined, a descriptive `ZodIssue` is pushed with the path to the offending element. Previously, `measureDepth` would silently short-circuit on missing IDs (`if (!el?.children?.length) return 0`), allowing dangling references to pass validation undetected. This could cause the client renderer to crash or silently skip elements at runtime.
|
@CryptoExplor is attempting to deploy a commit to the farcaster Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136
Adds a pass inside
validateStructurethat checks every element'schildrenarray against the keys ofui.elements. If a child ID is referenced but not defined, a descriptiveZodIssueis pushed with the path to the offending element.Previously,
measureDepthwould silently short-circuit on missing IDs (if (!el?.children?.length) return 0), allowing dangling references to pass validation undetected. This could cause the client renderer to crash or silently skip elements at runtime.