docs(snap): vertical stacks should default justify (omit it)#171
Open
bob-obringer wants to merge 1 commit intomainfrom
Open
docs(snap): vertical stacks should default justify (omit it)#171bob-obringer wants to merge 1 commit intomainfrom
bob-obringer wants to merge 1 commit intomainfrom
Conversation
llms.txt and SKILL.md now explicitly steer agents toward the implicit start packing for vertical content columns, and reserve `justify: "between"` / `"around"` / `"evenly"` for layouts that genuinely need children pushed to edges (a horizontal Back/Next nav row is the canonical case). This documents a foot-gun made visible by the recent text fix: text in a vertical stack no longer fills the column with flex-grow:1, so a stretched column whose snap set `justify: "between"` now spreads children across empty space rather than appearing packed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the text-rendering fix in #168, vertical stacks no longer fill via
flex-grow: 1on text children. That exposed a long-standing foot-gun: when a snap setsjustify: "between"on a vertical content column whose row peer is taller (e.g. a 9:16 image), the stretched column now has visible empty space, andspace-betweenspreads children across it. Reads as awkward, not designed.This PR steers agents toward the implicit
startpacking as the default for vertical content columns and reserves distributingjustifyvalues for cases that actually need them.Changes
apps/docs/public/SKILL.mdandapps/docs/public/2.0/SKILL.md— new bullet calling out the default and listing when to deviate (Back/Next nav row is the canonical exception).pkgs/snap/llms.txtandapps/docs/public/llms.txt— extendedstack.justifydescription with the same guidance.@farcaster/snap(sincellms.txtships with the package).Why this matters now
PR #168 changed text in vertical stacks from
flex-1tomin-w-0. Withflex-1, text greedily filled the column → no empty space →justify: "between"had nothing to distribute → bug was hidden. With the fix, the column's intrinsic height matches its content, the row'salign-items: stretchgives the column a tall stretched height, and the empty space distributes children to top + bottom edges.The framework behavior is correct (CSS doing what was asked); the agent's output is what needs to change. SKILL.md is the right place to fix it.
Test plan