Fix a factual error in 10-scaling-up-road-to-the-top-part-3.ipynb #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On [this point](https://youtu.be/p4ZZq0736Po?t=1104) of the L7 of Practical Deep Learning for Coders, you've explained that we pass the effective batch size to the constructor of the `GradientAccumulation` class. But the comment in the notebook doesn't match that fact and got a bit confusing to figure out what's the case actually.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Also, confirmed that directly passing a value in the constructor correctly sets it in the 
So its ok to pass the param directly or as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this point of the L7 of Practical Deep Learning for Coders, you've explained that we pass the effective batch size to the constructor of the
GradientAccumulationclass. But the comment in the notebook doesn't match that fact and got a bit confusing to figure out what's the case actually.https://github.com/fastai/fastai/blob/1ac4ee147baf86d2f66f13da9d755a4970f1160b/nbs/18a_callback.training.ipynb#L225-230
confirms this is the case.