👷🏻 Auto-generate frontend client #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svlandeg
reviewed
Sep 2, 2024
There was a problem hiding this comment.
Hey @alejsdev!
Apologies for the post-merge comment, but it looks like the newly introduced action from this PR makes the CI fail on PRs that are contributed from forks.
For instance, the "Generate clients" checks were failing on #1326 but were succesful on #1327. The two PRs are identical except for the fact that the first one is from my fork, and the second one from a branch from the main repo.
You can also see the CI failing on these PRs: #1319 & #1318.
The reason this fails, with a
Error: Input required and not supplied: token
I think is because the workflow on a branch from a fork doesn't have access to the ${{ github.token }} from the main repo (or something such). More details here: actions/checkout#298
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.