✨ Add field-level db comments when a field description exists #1293
+45
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svlandeg
reviewed
Feb 20, 2025
svlandeg
changed the title
iloveitaly
force-pushed
the
db-comments
branch
from
9f6e01c to
3db51e0
Compare
iloveitaly
force-pushed
the
db-comments
branch
from
ae4efaf to
67bea0f
Compare
|
@svlandeg awesome, will work on CI and we can go from there! Is there anything else that I should work on in order to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #492 (comment) by adding column-level db comments
when a field description exists.
I can add some tests if this is the sort of PR that would be accepted.
I've implemented this in my SQLModel extension here: https://github.com/iloveitaly/activemodel/blob/master/activemodel/get_column_from_field_patch.py
Details: