Skip to content

Add support for Annotated[..., Depends(...)] in CBV #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kapkekes wants to merge 2 commits into from
Closed

Add support for Annotated[..., Depends(...)] in CBV #347

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
253b1dd
Add `include_extras` at `get_type_hints` to save metadata
kapkekes Nov 11, 2024
5c5cb96
Add check for Python 3.8
kapkekes Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion fastapi_utils/cbv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import functools
import inspect
import sys
from typing import (
Any,
Callable,
Expand All @@ -16,6 +18,9 @@
from fastapi.routing import APIRoute
from starlette.routing import Route, WebSocketRoute

if sys.version_info >= (3, 9, 0):
get_type_hints = functools.partial(get_type_hints, include_extras=True)

PYDANTIC_VERSION = pydantic.VERSION
if PYDANTIC_VERSION[0] == "2":
from typing_inspect import is_classvar
Expand Down Expand Up @@ -74,7 +79,7 @@ def _init_cbv(cls: Type[Any], instance: Any = None) -> None:
]

dependency_names: List[str] = []
for name, hint in get_type_hints(cls).items():
for name, hint in get_type_hints(cls, include_extras=True).items():
if is_classvar(hint):
continue
parameter_kwargs = {"default": getattr(cls, name, Ellipsis)}
Expand Down
Loading