Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support bundle #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support bundle #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lib/fastlane/plugin/ionic/actions/ionic_action.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class IonicAction < Action
keystore_password: 'storePassword',
key_password: 'password',
keystore_alias: 'alias',
bundle: 'bundle',
build_number: 'versionCode',
min_sdk_version: 'gradleArg=-PcdvMinSdkVersion',
cordova_no_fetch: 'cordovaNoFetch'
Expand Down Expand Up @@ -99,6 +100,7 @@ def self.build(params)
args = [params[:release] ? '--release' : '--debug']
args << '--device' if params[:device]
args << '--prod' if params[:prod]
args << '--bundle' if params[:bundle]
args << '--browserify' if params[:browserify]

if !params[:cordova_build_config_file].to_s.empty?
Expand Down Expand Up @@ -126,9 +128,9 @@ def self.build(params)
end

if params[:platform].to_s == 'ios'
sh "ionic cordova compile #{params[:platform]} --no-interactive #{args.join(' ')} -- #{ios_args}"
sh "ionic cordova compile #{params[:platform]} --no-interactive #{args.join(' ')} -- #{ios_args}"
elsif params[:platform].to_s == 'android'
sh "ionic cordova compile #{params[:platform]} --no-interactive #{args.join(' ')} -- -- #{android_args}"
sh "ionic cordova compile #{params[:platform]} --no-interactive #{args.join(' ')} -- -- #{android_args}"
end
end

Expand Down Expand Up @@ -228,6 +230,13 @@ def self.available_options
is_string: true,
default_value: ''
),
FastlaneCore::ConfigItem.new(
key: :bundle,
env_name: "BUNDLE",
description: "Use bundle for android",
is_string: false,
default_value: 'true'
),
FastlaneCore::ConfigItem.new(
key: :keystore_path,
env_name: "CORDOVA_ANDROID_KEYSTORE_PATH",
Expand Down