Add env_name
definitions to ConfigItem
's that were missing them
#200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We leverage the
xcov
action in our Fastfile and it's great (thanks for the hard work so far 💪).One thing we are trying to do however is keep our main Fastfile as lean as possible to make it easy for people to parse what is going on.
The problem that we face however its that sometimes, we are required to pass the same arguments to an action in multiple places, but the duplication in the Fastfile becomes a bit noisy.
Instead, we have a pattern where we set sensible global defaults in a hidden lane via the environment variable. What we'd like is to take this:
And instead have this:
While most of this is possible today, there are a couple of config items that don't currently have a
env_name
defined.Changes
In this PR, I go through all of the options and I add the
env_name
definition if it was missing. I follow a relatively simple naming pattern ofXCOV_{KEY_TO_UPPER_CASE}
.