Fix release notes + version in docs #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, this fixes the autogenerated release notes, which we can check by downloading the build as an artifact: https://github.com/fastmachinelearning/hls4ml/suites/11957657003/artifacts/627077421 the versioning is still off, but that's a different problem... |
|
OK it's all working now (including version number)! check the latest artifact! https://github.com/fastmachinelearning/hls4ml/suites/11957927384/artifacts/627099082 resolution found via: actions/checkout#1049 |
vloncar
approved these changes
Apr 3, 2023
JanFSchulte
pushed a commit
to JanFSchulte/hls4ml
that referenced
this pull request
May 23, 2023
* Fix release notes? * upload artifact * try global git config * try more tricks * don't take ownership * Edit on GitHub
calad0i
pushed a commit
to calad0i/hls4ml
that referenced
this pull request
Jul 1, 2023
* Fix release notes? * upload artifact * try global git config * try more tricks * don't take ownership * Edit on GitHub
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the autogeneration of release notes.
Also fix version number.
Type of change
Checklist
pre-commiton the files I edited or added.