feat(sync): approve new devices without recovery keys - #6942
Merged
Conversation
ComputelessComputer
force-pushed
the
fix/cloudsync-device-enrollment
branch
from
August 20, 2026 02:55
b4d28e9 to
9d5d260
Compare
ComputelessComputer
force-pushed
the
fix/cloudsync-device-enrollment
branch
from
August 20, 2026 02:56
9d5d260 to
3a60611
Compare
✅ Deploy Preview for anarlog ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for anarlog canceled.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3a60611. Configure here.
Add an expiring, account-scoped enrollment mailbox with atomic device-cap replacement and authenticated API routes. Wire automatic desktop registration, trusted-device approval, recovery-key fallback, device management, generated clients, and coverage.
ComputelessComputer
force-pushed
the
fix/cloudsync-device-enrollment
branch
from
August 20, 2026 03:08
3a60611 to
246773a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Test plan
supabase test dbcargo check --workspace --all-targetscargo test --workspacecargo clippy --workspace --all-targets --locked -- -D warningspnpm -r typecheckpnpm -F desktop testpnpm exec oxlint --quiet --format=github apps/desktop/src/pnpm -F desktop i18n:checkNote
High Risk
Changes the encrypted sync onboarding and credential path (E2EE enrollment, device limits, Pro gating) and adds security-sensitive API surface; regressions could block sync or mishandle keys.
Overview
Adds device-to-device E2EE enrollment so a new desktop can join encrypted cloud sync after approval from an existing device, with recovery-key setup kept only for the first device or as a fallback.
The API gains
/sync/devices(list/remove) and/sync/e2ee/device-enrollments(register, seal, consume) plus OpenAPI types for pending/sealed enrollment packages. The desktopsync-devicesclient drives Sync settings (approve, remove, replace at the 5-device cap) andcloudsyncnow registers the local device, polls whileapproval_pending, imports a sealed package, then continues credential exchange—handling 409 (no existing key yet), 403 device limit, and updated limit toasts/copy.Copy and translations shift onboarding from “paste recovery key on every device” to approve from another signed-in device, with “Use recovery key instead” where needed.
Reviewed by Cursor Bugbot for commit 246773a. Bugbot is set up for automated code reviews on this repo. Configure here.