fix(desktop): show clipped transcript selection borders - #6976
Draft
ComputelessComputer wants to merge 1 commit into
Draft
fix(desktop): show clipped transcript selection borders#6976ComputelessComputer wants to merge 1 commit into
ComputelessComputer wants to merge 1 commit into
Conversation
Selected entries used an outset ring, which overflow-x-clip on the virtualized list also clipped on the top and bottom. Draw the ring inside the segment so the horizontal borders stay visible. Co-authored-by: John Jeong <ComputelessComputer@users.noreply.github.com>
✅ Deploy Preview for anarlog canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selected transcript entries used an outset
ring-1, and the virtualized list clips horizontal overflow withoverflow-x-clip. That also clips overflow on the other axis, so the top and bottom selection borders disappeared—especially on the first entry under the toolbar and on consecutive selected blocks.Draw the selection ring inside the segment (
ring-inset) so those horizontal borders stay visible without changing the speaker-label overflow clip.Test plan
pnpm exec dprint fmt+ scopeddprint checkon changed filespnpm exec oxlint --quiet --format=github apps/desktop/src/pnpm -F desktop typecheckpnpm -F desktop exec vitest run src/session/components/note-input/transcript/renderer/segment.test.tsx