Give folders a dedicated workspace view - #7190
Merged
Merged
Conversation
✅ Deploy Preview for anarlog canceled.
|
ComputelessComputer
force-pushed
the
fix/workspace-folders-settings
branch
from
August 31, 2026 05:36
bdae521 to
d95814f
Compare
ComputelessComputer
force-pushed
the
fix/workspace-folders-settings
branch
2 times, most recently
from
August 31, 2026 06:57
bae95ec to
153facf
Compare
ComputelessComputer
force-pushed
the
fix/workspace-folders-settings
branch
from
August 31, 2026 07:47
153facf to
bbadc52
Compare
Workspace > Folders is where you create folders, set chat instructions, and attach a syllabus after the sidebar filter entry point went away.
Settings still links to Folders, but the list lives in a dedicated sidebar and the editor is the main pane.
It matches the summary template selector and opens the dedicated folders view, selecting the current note's folder when one is set.
cmdk was focusing No folder first, so the list looked empty even when Sales was selected.
Drop the No folder row from the picker so the current folder is the only selected-looking item.
Add sidebar search, drop the Folders page title, and let each folder pick an icon the same way templates do.
Rename inline like a note title, drop subfolders, and move delete into a ⋯ menu.
The picker was controlled from a live query, so the glyph snapped back until a second catalog write landed. Keep the chosen icon in UI state, write catalog + icon_json together, and use the same icon on notes.
Keep the folder workspace translation catalogs aligned with its own source boundary.
Clear only the matching optimistic icon when persistence fails so later persisted or synced values stay visible.
The body sat in extra padding, the textarea was cramped, and the add control was a faint header plus. Context copy is now shorter, and materials start with a plus tile in a grid.
ComputelessComputer
force-pushed
the
fix/workspace-folders-settings
branch
from
August 31, 2026 08:05
bbadc52 to
f03151b
Compare
Skip deleted folder trees immediately and show full paths for nested folders.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0ed353c. Configure here.
Regenerate compiled locale modules against the current main branch.
Clear deleted-folder suppression when the note picker recreates that path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Problem: After the notes filter menu lost folder entry points, folder instructions and materials were hard to reach. Putting that UI inside Settings also made the folder list feel like a preference instead of a workspace, and the note folder picker highlighted "No folder" even when a folder like Sales was already selected.
Fix: Folders is now its own workspace, like Templates. Settings still links to it. The note folder picker has See all folders, highlights the current folder, and keeps No folder as a clear action below the list.
Verification
pnpm -F desktop exec vitest run src/session/components/folder-picker.test.tsx src/folders/index.test.tsx src/sidebar/settings.test.tsx src/store/zustand/tabs/basic.test.tspnpm -F desktop typecheckpnpm exec oxlint --quiet --format=github apps/desktop/src/folders apps/desktop/src/session/components/folder-picker.tsxNote
Medium Risk
New UI surface for folder rename, delete, and material uploads that calls existing catalog and attachment APIs; mistakes could delete folder trees or lose materials, but notes are explicitly preserved.
Overview
Adds a Folders workspace (sidebar list + main editor) so users can manage folders outside Settings—create, search, rename, pick icons, edit context, upload/remove materials, and delete with confirmation.
Folder editor wires to existing session APIs (
renameNamedFolder,deleteNamedFolder, folder attachments) and a Zustand selection store for active path, optimistic icon overrides, and hiding deleted paths until queries refresh.Note folder picker now shows the current folder with a check, toggles off folder assignment by re-selecting the active folder, adds See all folders to open the workspace on the current path, and drops a separate No folder row from the list.
Settings Workspace → Folders navigates to the new tab type
{ type: "folders" }instead of embedding folder management in the sidebar. i18n strings move fromfolder-materialsto the newfoldersmodule; delete copy clarifies nested folders and materials are removed while notes stay in All notes.Reviewed by Cursor Bugbot for commit 42bcadd. Bugbot is set up for automated code reviews on this repo. Configure here.