Skip to content

Give folders a dedicated workspace view - #7190

Merged
ComputelessComputer merged 17 commits into
mainfrom
fix/workspace-folders-settings
Aug 31, 2026
Merged

Give folders a dedicated workspace view#7190
ComputelessComputer merged 17 commits into
mainfrom
fix/workspace-folders-settings

Conversation

@ComputelessComputer

@ComputelessComputer ComputelessComputer commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

Problem: After the notes filter menu lost folder entry points, folder instructions and materials were hard to reach. Putting that UI inside Settings also made the folder list feel like a preference instead of a workspace, and the note folder picker highlighted "No folder" even when a folder like Sales was already selected.

Fix: Folders is now its own workspace, like Templates. Settings still links to it. The note folder picker has See all folders, highlights the current folder, and keeps No folder as a clear action below the list.

Verification

  • pnpm -F desktop exec vitest run src/session/components/folder-picker.test.tsx src/folders/index.test.tsx src/sidebar/settings.test.tsx src/store/zustand/tabs/basic.test.ts
  • pnpm -F desktop typecheck
  • pnpm exec oxlint --quiet --format=github apps/desktop/src/folders apps/desktop/src/session/components/folder-picker.tsx
  • Open Settings → Workspace → Folders and confirm the list is in the sidebar
  • Open a note in Sales, open the folder picker, and confirm Sales is highlighted with a check; No folder is below it
  • Click See all folders and confirm it opens the Folders workspace on Sales

Note

Medium Risk
New UI surface for folder rename, delete, and material uploads that calls existing catalog and attachment APIs; mistakes could delete folder trees or lose materials, but notes are explicitly preserved.

Overview
Adds a Folders workspace (sidebar list + main editor) so users can manage folders outside Settings—create, search, rename, pick icons, edit context, upload/remove materials, and delete with confirmation.

Folder editor wires to existing session APIs (renameNamedFolder, deleteNamedFolder, folder attachments) and a Zustand selection store for active path, optimistic icon overrides, and hiding deleted paths until queries refresh.

Note folder picker now shows the current folder with a check, toggles off folder assignment by re-selecting the active folder, adds See all folders to open the workspace on the current path, and drops a separate No folder row from the list.

Settings Workspace → Folders navigates to the new tab type { type: "folders" } instead of embedding folder management in the sidebar. i18n strings move from folder-materials to the new folders module; delete copy clarifies nested folders and materials are removed while notes stay in All notes.

Reviewed by Cursor Bugbot for commit 42bcadd. Bugbot is set up for automated code reviews on this repo. Configure here.

@netlify

netlify Bot commented Aug 31, 2026

Copy link
Copy Markdown

Deploy Preview for anarlog canceled.

Name Link
🔨 Latest commit 42bcadd
🔍 Latest deploy log https://app.netlify.com/projects/anarlog/deploys/6a954fd58c3abc00083ac38d

@ComputelessComputer
ComputelessComputer force-pushed the fix/workspace-folders-settings branch from bdae521 to d95814f Compare August 31, 2026 05:36
Comment thread apps/desktop/src/folders/selection.ts
Comment thread apps/desktop/src/folders/folder-editor.tsx Outdated
Comment thread apps/desktop/src/folders/folder-editor.tsx
@ComputelessComputer
ComputelessComputer force-pushed the fix/workspace-folders-settings branch 2 times, most recently from bae95ec to 153facf Compare August 31, 2026 06:57
Comment thread apps/desktop/src/folders/folder-editor.tsx
@ComputelessComputer
ComputelessComputer force-pushed the fix/workspace-folders-settings branch from 153facf to bbadc52 Compare August 31, 2026 07:47
Comment thread apps/desktop/src/folders/selection.ts
Comment thread apps/desktop/src/folders/sidebar.tsx Outdated
Workspace > Folders is where you create folders, set chat instructions, and attach a syllabus after the sidebar filter entry point went away.
Settings still links to Folders, but the list lives in a dedicated sidebar and the editor is the main pane.
It matches the summary template selector and opens the dedicated folders view, selecting the current note's folder when one is set.
cmdk was focusing No folder first, so the list looked empty even when Sales was selected.
Drop the No folder row from the picker so the current folder is the only selected-looking item.
Add sidebar search, drop the Folders page title, and let each folder pick an icon the same way templates do.
Rename inline like a note title, drop subfolders, and move delete into a ⋯ menu.
The picker was controlled from a live query, so the glyph snapped back until a second catalog write landed. Keep the chosen icon in UI state, write catalog + icon_json together, and use the same icon on notes.
Keep the folder workspace translation catalogs aligned with its own source boundary.
Clear only the matching optimistic icon when persistence fails so later persisted or synced values stay visible.
The body sat in extra padding, the textarea was cramped, and the add control was a faint header plus. Context copy is now shorter, and materials start with a plus tile in a grid.
@ComputelessComputer
ComputelessComputer force-pushed the fix/workspace-folders-settings branch from bbadc52 to f03151b Compare August 31, 2026 08:05
Comment thread apps/desktop/src/folders/folder-editor.tsx
Skip deleted folder trees immediately and show full paths for nested folders.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0ed353c. Configure here.

Comment thread apps/desktop/src/folders/selection.ts
Regenerate compiled locale modules against the current main branch.
Clear deleted-folder suppression when the note picker recreates that path.
@ComputelessComputer
ComputelessComputer merged commit 77ff162 into main Aug 31, 2026
28 of 29 checks passed
@ComputelessComputer
ComputelessComputer deleted the fix/workspace-folders-settings branch August 31, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant