Remember the last mobile sign-in method - #7207
Merged
Merged
Conversation
✅ Deploy Preview for anarlog canceled.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ComputelessComputer
force-pushed
the
fix/mobile-last-used-sign-in
branch
2 times, most recently
from
August 31, 2026 07:19
7dedb31 to
d975b54
Compare
ComputelessComputer
force-pushed
the
fix/mobile-last-used-sign-in
branch
from
August 31, 2026 07:53
9ae1748 to
d0b6c6f
Compare
ComputelessComputer
force-pushed
the
fix/mobile-last-used-sign-in
branch
from
August 31, 2026 08:06
d0b6c6f to
7fd181d
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b79d742. Configure here.
ComputelessComputer
force-pushed
the
fix/mobile-last-used-sign-in
branch
from
August 31, 2026 09:56
b79d742 to
fa7f727
Compare
Carry the completed email or reauthentication method into the callback URL.
Carry the provider or auth view through desktop retries before falling back to remembered state.
ComputelessComputer
force-pushed
the
fix/mobile-last-used-sign-in
branch
from
August 31, 2026 10:04
fa7f727 to
0132bd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches auth callback handling and session deduplication; incorrect method propagation or race behavior could affect sign-in UX but not broad security surface area.
Overview
Adds last-used sign-in method on mobile: the auth provider loads and saves the method in AsyncStorage after a successful browser handoff, exposes
lastSignInMethodon context, and the sign-in sheet highlights the matching provider with a Last used badge.The web auth handoff now carries an optional
methodquery param through desktop/mobile deeplinks and/callback/authredirects (OAuth, email password desktop flow, OTP confirm, and existing-user desktop reauth), so the app can learn the method from the callback URL when present. Mobile also awaits session setup on duplicate deep links by sharing in-flightsetSessionpromises instead of dropping repeat callbacks.Unit tests cover method parsing on mobile and callback/deeplink builders on web.
Reviewed by Cursor Bugbot for commit 0132bd3. Bugbot is set up for automated code reviews on this repo. Configure here.