Remove orphaned deploy workflows and harden API replacement - #7232
Merged
Conversation
✅ Deploy Preview for anarlog canceled.
|
ComputelessComputer
marked this pull request as ready for review
September 1, 2026 13:08
ComputelessComputer
deleted the
chore/remove-orphaned-deploy-workflows
branch
September 1, 2026 13:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem: Removed bot and internal Slack services still had CI or deployment workflows, while API rolling replacement could fail when Fly had not propagated a newly pushed image manifest yet.
Fix: Delete the orphaned workflows and retry only Fly manifest-propagation errors during replacement-machine creation, with a focused regression test.
Verification
Note
Low Risk
Workflow deletions only affect removed apps; deploy retry is narrowly scoped to manifest propagation errors during machine creation.
Overview
Removes orphaned GitHub Actions for services that no longer ship:
bot_ci.yaml,bot_cd.yaml, andslack_internal_cd.yaml(bot typecheck/test and Fly deploys for bot and slack-internal).Hardens API drain deploy by retrying replacement-machine creation when Fly returns HTTP 400 for a not-yet-available image manifest (
MANIFEST_UNKNOWN/manifest unknown), using the same attempt count and exponential backoff as other Fly API retries indeploy_api_drain.py. A regression test asserts a failed first POST is retried after0.5sand then succeeds.Reviewed by Cursor Bugbot for commit 4dfde62. Bugbot is set up for automated code reviews on this repo. Configure here.